git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Pavel Roskin <proski@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Making CFLAGS compilant with GNU Coding Standards
Date: Mon, 08 Aug 2005 13:53:24 -0700	[thread overview]
Message-ID: <7vy87c2lrv.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <1123306575.7588.17.camel@dv.roinet.com> (Pavel Roskin's message of "Sat, 06 Aug 2005 01:36:15 -0400")

Pavel Roskin <proski@gnu.org> writes:

> Quoting GNU Coding Standards ("info standards"):
>
> "If there are C compiler options that _must_ be used for proper
> compilation of certain files, do not include them in `CFLAGS'.  Users
> expect to be able to specify `CFLAGS' freely themselves."

Quoting Documentation/CodingStyle:

    This is a short document describing the preferred coding style for the
    linux kernel.  Coding style is very personal, and I won't _force_ my
    views on anybody, but this is what goes for anything that I have to be
    able to maintain, and I'd prefer it for most other things too.  Please
    at least consider the points made here.

    First off, I'd suggest printing out a copy of the GNU coding
    standards, and NOT read it.  Burn them, it's a great symbolic
    gesture.

This was only a tongue-in-cheek comment ;-).

Seriously, I do not intend to discarded this patch, but I am
currently not taking Makefile patches unless they fix real
breakage.

I do want to revisit Makefile issues after 0.99.4, along with
the changes Pasky sent several days ago.  Please remind me about
them after Wednesday.

  reply	other threads:[~2005-08-08 20:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-06  5:36 [PATCH] Making CFLAGS compilant with GNU Coding Standards Pavel Roskin
2005-08-08 20:53 ` Junio C Hamano [this message]
2005-08-08 23:10   ` Ryan Anderson
2005-08-08 23:42     ` Johannes Schindelin
2005-08-09  2:48       ` Junio C Hamano
2005-08-09 10:17         ` Sanity check of git-commit patch, was " Johannes Schindelin
2005-08-09 12:53           ` Junio C Hamano
2005-08-09 14:19             ` Johannes Schindelin
2005-08-09 17:00               ` Junio C Hamano
2005-08-10  2:20                 ` Horst von Brand
2005-08-10 12:52                   ` Johannes Schindelin
2005-08-10  5:45             ` Junio C Hamano
2005-08-09 12:56     ` Junio C Hamano
2005-08-11  4:01   ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy87c2lrv.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).