From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH v6] Add new git-related helper to contrib
Date: Thu, 23 May 2013 11:34:26 -0700 [thread overview]
Message-ID: <7vzjvleea5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7v8v35hc11.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 23 May 2013 09:54:50 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Users of full-output may want to be able to see the same thing.
... but I agree we may be able to cheat if we only want to support
interactive, and we do want to find a way to cheat when we are
running interactive without having to store much more information in
each blame_entry.
> Imagine that your scoreboard originally has three blocks of text
> ...
> in that situation?
(I snipped everything I said in the previous reply only for
brevity but they are still relevant).
I _think_ one way to "cheat" without storing too much information in
each blame_entry is to first make a copy of all the original blame
entries that share the "suspect", see if any line in the line range
represented by each of the blame entries ended up being blamed to an
origin with a path different from that of the "suspect". And print
those original blame entries that fits the criterion as additional
"these are not the final blame as you are digging with the option to
detect copy across files, but at this commit this line appeared anew
as far as the origin->path is concerned" output.
So I think you were going in the right direction (in other words,
the patch inserted new code to the right places), even though you
may have got the details in what the new code should do wrong.
next prev parent reply other threads:[~2013-05-23 18:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 15:53 [PATCH v6] Add new git-related helper to contrib Felipe Contreras
2013-05-20 1:47 ` Eric Sunshine
2013-05-22 19:23 ` Junio C Hamano
2013-05-22 19:54 ` Junio C Hamano
2013-05-22 22:23 ` Felipe Contreras
2013-05-22 22:38 ` Junio C Hamano
2013-05-22 22:43 ` Felipe Contreras
2013-05-22 22:53 ` Junio C Hamano
2013-05-22 22:58 ` Junio C Hamano
2013-05-22 23:42 ` Junio C Hamano
2013-05-22 23:57 ` Felipe Contreras
2013-05-23 0:08 ` Junio C Hamano
2013-05-23 4:07 ` Felipe Contreras
2013-05-23 5:22 ` Felipe Contreras
2013-05-23 16:54 ` Junio C Hamano
2013-05-23 18:34 ` Junio C Hamano [this message]
2013-05-23 21:33 ` Felipe Contreras
2013-05-23 21:52 ` Junio C Hamano
2013-05-23 21:58 ` Felipe Contreras
2013-05-23 22:44 ` Junio C Hamano
2013-05-23 22:59 ` Felipe Contreras
2013-05-23 23:47 ` Junio C Hamano
2013-05-24 0:22 ` Felipe Contreras
2013-05-23 3:23 ` Felipe Contreras
2013-05-23 3:50 ` Felipe Contreras
2013-05-23 17:05 ` Junio C Hamano
2013-05-22 23:19 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzjvleea5.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox