git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] Feeding an annotated but unsigned tag to "git merge"
Date: Wed, 06 Jun 2012 09:37:52 -0700	[thread overview]
Message-ID: <7vzk8gmm5b.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120606134207.GB2597@sigill.intra.peff.net> (Jeff King's message of "Wed, 6 Jun 2012 09:42:07 -0400")

Jeff King <peff@peff.net> writes:

> On Tue, Jun 05, 2012 at 12:58:30PM -0700, Junio C Hamano wrote:
> ...
>> But since I've written it already, I thought it might be worth
>> showing it to the list for discussion, if only to publicly reject
>> the idea ;-).
>
> It has been nearly a day, and nobody has publicly rejected it. So I will
> do so. :)
>
> This just doesn't make sense to me. Why would we treat annotated but
> unsigned tags differently from signed tags? In both cases, the new
> behavior is keeping more information about what happened, which is
> generally a good thing.
>
> I haven't seen any good argument against creating these merges[1].

It is in line with --ff-only special casing, though.  The argument
against it is that "we used to fast forward", I would think, even
though in general my reaction to that would be "so what?" because I
agree with your "keeping more information instead of discarding as
we used to is a good feature enhancement, why should we retreat?"

> [1] From the tone of your message, I think you are not the right person
>     to be arguing that side, anyway. It sounds as though you are not all
>     that invested in this series. :)

I am actually ambivalent; instead of being 0% supportive like I
usually am for many topics, perhaps I am 30% sympathetic to this
one.

This was triggered by
http://thread.gmane.org/gmane.comp.version-control.git/198828

  reply	other threads:[~2012-06-06 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05 19:58 [PATCH 0/2] Feeding an annotated but unsigned tag to "git merge" Junio C Hamano
2012-06-05 19:58 ` [PATCH 1/2] merge: separte the logic to check for a signed tag Junio C Hamano
2012-06-05 19:58 ` [PATCH 2/2] merge: allow fast-forwarding to an annotated but unsigned tag Junio C Hamano
2012-06-06 13:42 ` [PATCH 0/2] Feeding an annotated but unsigned tag to "git merge" Jeff King
2012-06-06 16:37   ` Junio C Hamano [this message]
2012-06-07  9:09     ` Jeff King
2012-06-07 16:17       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzk8gmm5b.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).