git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v3 0/2] test: tests for the "double > from mailmap" bug
Date: Tue, 14 Feb 2012 14:49:39 -0800	[thread overview]
Message-ID: <7vzkcl3u9o.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAMP44s0cJroUM2aahRQz2dVPe57XPPOnsxWy+5DfmjXGArz4wA@mail.gmail.com> (Felipe Contreras's message of "Wed, 15 Feb 2012 00:34:21 +0200")

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Wed, Feb 15, 2012 at 12:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
> And I don't understand why people want the obvious to be explained.

Has it ever occurred to you the reason why people ask questions to you is
perhaps because something that is obvious to you who wrote the patch is
not obvious at all to others?  Has it also occurred to you that the
majority of people who need to understand the patch during the review and
6 months down the road in "git log" output are not *you*?

> Your new point is "you can add a new thing that we did not have, but
> it would not result in a good addition if that new thing is
> irrelevant", but you already know what is the new thing from the
> summary "'git blame -e' tests".

It is not a "new point".  Jonathan, Peff and I all never said that it is
unclear "what" your patch adds.  The suggestions for improvement given in
this thread were all to explain "why" better.

> Everybody seems to assume that a simple commit message = bad. I disagree.

If you find *everybody* seems to disagree with you, it would help to
consider a slight possibility that you *might* be wrong.  And "simple" is
not necessarily "sufficient and simple".

> ... And I already pointed out the double standards.

Sorry, but the absolute uniform standards do not exist, unless you are
living in a fantasy land.  I expect better from list regulars as new
contributors will inevitably learn from their behaviour (we also learn
from our past mistakes).

  reply	other threads:[~2012-02-14 22:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 16:11 [PATCH 0/2] t: add blame -e tests for mailmap Felipe Contreras
2012-02-14 16:11 ` [PATCH 1/2] t: mailmap: add 'git blame -e' tests Felipe Contreras
2012-02-14 16:11 ` [PATCH 2/2] t: mailmap: add simple name translation test Felipe Contreras
2012-02-14 20:10   ` Junio C Hamano
2012-02-14 20:28     ` Felipe Contreras
2012-02-14 20:34 ` [PATCH v3 0/2] test: tests for the "double > from mailmap" bug Jonathan Nieder
2012-02-14 20:35   ` [PATCH 1/2] test: mailmap can change author name without changing email Jonathan Nieder
2012-02-14 21:35     ` Felipe Contreras
2012-02-14 21:50       ` Jonathan Nieder
2012-02-14 22:48         ` Felipe Contreras
2012-02-14 20:36   ` [PATCH 2/2] test: check that "git blame -e" uses mailmap correctly Jonathan Nieder
2012-02-14 21:41     ` Felipe Contreras
2012-02-14 21:59       ` Jonathan Nieder
2012-02-14 22:56         ` Felipe Contreras
2012-02-14 21:06   ` [PATCH v3 0/2] test: tests for the "double > from mailmap" bug Felipe Contreras
2012-02-14 21:15     ` Jonathan Nieder
2012-02-14 22:09       ` Felipe Contreras
2012-02-14 22:21         ` Jonathan Nieder
2012-02-14 22:36           ` Felipe Contreras
2012-02-14 21:14   ` Jeff King
2012-02-14 21:27     ` Jonathan Nieder
2012-02-14 21:52     ` Felipe Contreras
2012-02-14 22:07       ` Jeff King
2012-02-14 22:22         ` Felipe Contreras
2012-02-14 22:35           ` Jeff King
2012-02-14 22:18       ` Junio C Hamano
2012-02-14 22:34         ` Felipe Contreras
2012-02-14 22:49           ` Junio C Hamano [this message]
2012-02-14 23:14             ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzkcl3u9o.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).