From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: [PATCH 4/7] refactor git_getpass into generic prompt function
Date: Fri, 09 Dec 2011 15:58:06 -0800 [thread overview]
Message-ID: <7vzkf1b8mp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20111208083133.GD26409@sigill.intra.peff.net
Jeff King <peff@peff.net> writes:
> 2. The first series had a special "name" parameter just for generating
> error messages. This drops it in the name of simplicity, so error
> messages have gone from (assuming you don't have a tty):
>
> Could not read password: No such device or address
>
> to:
>
> Could not read 'Username for 'https://example.com': ': No such
> device or address
>
> which is verbose, yes, but contains a little more useful
> information. The formatting is rather unfortunate,...
It also would be unpleasant to i18n it, I suspect.
> + r = getpass(prompt);
> + if (!r)
> + die_errno("could not read '%s'", prompt);
Taking advantage of the "prompt-string"-ness of the message, this might be
a cuter workaround:
fatal: Password: <<could not be read>>
But I do not think it matters that much. Let's queue what you have, and
work out these details in-tree.
next prev parent reply other threads:[~2011-12-09 23:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 8:21 [PATCHv2 0/7] getpass refactoring Jeff King
2011-12-08 8:23 ` [PATCH 1/7] imap-send: avoid buffer overflow Jeff King
2011-12-08 8:24 ` [PATCH 2/7] imap-send: don't check return value of git_getpass Jeff King
2011-12-08 8:24 ` [PATCH 3/7] move git_getpass to its own source file Jeff King
2011-12-08 8:31 ` [PATCH 4/7] refactor git_getpass into generic prompt function Jeff King
2011-12-09 23:58 ` Junio C Hamano [this message]
2011-12-08 8:33 ` [PATCH 5/7] add generic terminal " Jeff King
2011-12-08 21:48 ` Jakub Narebski
2011-12-08 21:52 ` Jeff King
2011-12-08 8:33 ` [PATCH 6/7] prompt: use git_terminal_prompt Jeff King
2011-12-08 8:33 ` [PATCH 7/7] credential: use git_prompt instead of git_getpass Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzkf1b8mp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).