From: Junio C Hamano <gitster@pobox.com>
To: Hui Wang <jason77.wang@gmail.com>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH] sha1_file: Remove relative entries limitation
Date: Fri, 02 Sep 2011 09:22:31 -0700 [thread overview]
Message-ID: <7vzkimlxrs.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4E60A699.9080302@gmail.com> (Hui Wang's message of "Fri, 2 Sep 2011 17:49:13 +0800")
Hui Wang <jason77.wang@gmail.com> writes:
> Does this patch make sense?
I do not see anything wrong with it per-se, but I'd like to see somebody
made an effort to dig why the restriction is there in the first place. The
check is very much deliberately placed there and there may be a good
reason why we do not resolve relatives of indirect alternates that you are
missing when you wrote the patch (and I am missing when I wrote this
response).
prev parent reply other threads:[~2011-09-02 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 6:41 [PATCH] sha1_file: Remove relative entries limitation Hui Wang
2011-09-02 9:49 ` Hui Wang
2011-09-02 16:22 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzkimlxrs.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jason77.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).