From: Junio C Hamano <gitster@pobox.com>
To: Eric Blake <eblake@redhat.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Documentation: enhance gitignore whitelist example
Date: Tue, 05 Apr 2011 14:51:01 -0700 [thread overview]
Message-ID: <7vzko4l64a.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4D9B8862.1050605@redhat.com> (Eric Blake's message of "Tue, 05 Apr 2011 15:23:46 -0600")
Eric Blake <eblake@redhat.com> writes:
> On 04/05/2011 03:15 PM, Johannes Sixt wrote:
>>>> @@ -87,7 +89,8 @@ PATTERN FORMAT
>>>>
>>>> - Otherwise, git treats the pattern as a shell glob suitable
>>>> for consumption by fnmatch(3) with the FNM_PATHNAME flag:
>>>> - wildcards in the pattern will not match a / in the pathname.
>>>> + wildcards in the pattern will not match a / in the pathname,
>>>> + and do not ignore files with a leading . in the pathname.
>>
>> I don't think this is correct. * matches .gitignore. I tried it.
>
> That was my point. * _does_ match .gitignore, even though for normal
> shell globs, FNM_PERIOD is set and * does not match .gitignore. That
> is, while in the shell 'dir/*' only matches non-dot files, in .gitignore
> it matches all files including dot-files.
>
> Any ideas for a better way to word that?
Instead of "and do not ignore files with a leading", say "but will match
a dot '.'". You are talking about the rule for wildcards to match or not
to match the pathname and there is no room for the word "ignore" to come
into play in this sentence.
next prev parent reply other threads:[~2011-04-05 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 19:36 [PATCH] Documentation: enhance gitignore whitelist example Eric Blake
2011-04-05 19:40 ` Jonathan Nieder
2011-04-05 21:15 ` Johannes Sixt
2011-04-05 21:23 ` Eric Blake
2011-04-05 21:41 ` Jonathan Nieder
2011-04-05 21:49 ` Eric Blake
2011-04-05 21:51 ` Junio C Hamano [this message]
2011-04-05 21:39 ` Junio C Hamano
2011-04-05 20:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzko4l64a.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=eblake@redhat.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).