From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] ignore unknown color configuration
Date: Sun, 13 Dec 2009 18:33:13 -0800 [thread overview]
Message-ID: <7vzl5mjndi.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20091212222046.GA25973@coredump.intra.peff.net> (Jeff King's message of "Sat\, 12 Dec 2009 17\:20\:47 -0500")
Jeff King <peff@peff.net> writes:
> On Sat, Dec 12, 2009 at 01:45:45PM -0800, Junio C Hamano wrote:
>
>> This is a sane thing to do, as "slot" is part of the name of the variable,
>> and we generally do not warn upon seeing a misspelled variable name (it
>> makes it worse that "func" is not even misspelled but merely unknown to
>> older version of git in your scenario).
>>
>> On the other hand, I suspect that most people would apprecfiate if their
>> git pointed out "diff.color.finc? What do you mean?" before they waste
>> 30 minutes wondering why the new feature in 1.6.6 does not work for them.
>
> I would be more sympathetic to that user if this weren't the _only_ set
> of variables with this property. They don't get warned for diff.externel
> or color.show-branch.
True and fair enough. Let's have this in 1.6.6 then.
next prev parent reply other threads:[~2009-12-14 2:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 12:25 [PATCH/RFC] ignore unknown color configuration Jeff King
2009-12-12 21:45 ` Junio C Hamano
2009-12-12 22:20 ` Jeff King
2009-12-14 2:33 ` Junio C Hamano [this message]
2009-12-16 1:25 ` Junio C Hamano
2009-12-16 3:45 ` Jeff King
2009-12-16 1:29 ` Junio C Hamano
2009-12-16 3:46 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzl5mjndi.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox