Re: [PATCH 18/18] http*: add helper methods for fetching objects (loose)

[Junio C Hamano <gitster@pobox.com>]

Tay Ray Chuan <rctay89@gmail.com> writes:

> ...
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>

I think you can guess what my suggestion would be for the proposed commit
log message from comments to other patches, so I won't repeat them for
this patch.

You make a couple of variables no longer necessary with this patch; please
squash this in when rerolling.

 http-push.c   |    1 -
 http-walker.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/http-push.c b/http-push.c
index 122cf56..386552c 100644
--- a/http-push.c
+++ b/http-push.c
@@ -524,7 +524,6 @@ static void release_request(struct transfer_request *request)
 
 static void finish_request(struct transfer_request *request)
 {
-	struct stat st;
 	struct http_pack_request *preq;
 	struct http_object_request *obj_req;
 
diff --git a/http-walker.c b/http-walker.c
index 95a1e9b..8a617ae 100644
--- a/http-walker.c
+++ b/http-walker.c
@@ -152,7 +152,6 @@ static void prefetch(struct walker *walker, unsigned char *sha1)
 	struct object_request *newreq;
 	struct object_request *tail;
 	struct walker_data *data = walker->data;
-	char *filename = sha1_file_name(sha1);
 
 	newreq = xmalloc(sizeof(*newreq));
 	newreq->walker = walker;