From: Junio C Hamano <gitster@pobox.com>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH 06/18] Don't expect verify_pack() callers to set pack_size
Date: Sun, 24 May 2009 13:43:39 -0700 [thread overview]
Message-ID: <7vzld2teo4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20090524221947.c83d6aba.rctay89@gmail.com
Tay Ray Chuan <rctay89@gmail.com> writes:
> Since use_pack() will end up populating pack_size if it is not already set,
> we can just adapt the code in verify_packfile() such that it doesn't require
> pack_size to be set beforehand.
>
> This allows callers not to have to set pack_size themselves, and we can thus
> revert changes from 1c23d794 (Don't die in git-http-fetch when fetching packs).
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
When you forward somebody else's patch, please be careful not to lose the
attribution, by having
From: Mike Hommey <mh@glandium.org>
Date: <<<the original author date from Mike>>>
and an empty line before you start the commit log message.
prev parent reply other threads:[~2009-05-24 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 14:19 [PATCH 06/18] Don't expect verify_pack() callers to set pack_size Tay Ray Chuan
2009-05-24 20:43 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzld2teo4.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).