From: Junio C Hamano <gitster@pobox.com>
To: Carlos Rica <jasampler@gmail.com>
Cc: git@vger.kernel.org, johannes.schindelin@gmx.de
Subject: Re: [PATCH] builtin-tag.c: remove global variable to use the callback data of git-config.
Date: Tue, 10 Mar 2009 09:36:56 -0700 [thread overview]
Message-ID: <7vzlft8hcn.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1236690219.20402.28.camel@luis-desktop> (Carlos Rica's message of "Tue, 10 Mar 2009 14:03:39 +0100")
Carlos Rica <jasampler@gmail.com> writes:
> Signed-off-by: Carlos Rica <jasampler@yahoo.es>
> ---
>
> This way the data flow is much clearer.
Good. I think the Subject is backwards, though.
next prev parent reply other threads:[~2009-03-10 16:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 13:03 [PATCH] builtin-tag.c: remove global variable to use the callback data of git-config Carlos Rica
2009-03-10 13:34 ` Johannes Schindelin
2009-03-10 14:00 ` Carlos Rica
2009-03-10 16:36 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-14 7:17 Carlos Rica
2009-03-14 20:54 ` Junio C Hamano
2009-03-16 11:46 ` Carlos Rica
2009-03-17 14:43 Carlos Rica
2009-03-17 15:47 ` Johannes Schindelin
2009-03-17 17:57 ` Carlos Rica
2009-03-17 18:45 ` Junio C Hamano
2009-03-17 22:27 ` Johannes Schindelin
2009-03-18 0:50 ` Carlos Rica
2009-03-24 19:54 Carlos Rica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzlft8hcn.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).