git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
	Johannes.Schindelin@gmx.de, jnareb@gmail.com
Subject: Re: [PATCH v2 4/5] Add some tests of git-cvsimport's handling of vendor branches
Date: Sun, 22 Feb 2009 08:49:24 -0800	[thread overview]
Message-ID: <7vzlge1kob.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 62960fa97012833859a8f4f8d68a625f8851f8be.1235220105.git.mhagger@alum.mit.edu

Michael Haggerty <mhagger@alum.mit.edu> writes:

> CVS's handling of vendor branches is tricky; add some tests to check
> whether revisions added via "cvs imports" then imported to git via
> "git cvsimport" are reflected correctly on master.
> ...
> One of these tests fail and is therefore marked "test_expect_failure".

In addition to the one marked with expect-failure, 2, 4, 6, 7, 8 and 9
seems to fail for me as well.

    $ sh t9601-cvsimport-vendor-branch.sh -i -v
    Initialized empty Git repository in /git/git.git/t/trash directory.t9601-cvsimport-vendor-branch/.git/
    * expecting success:

            git cvsimport -C module-git module


    Initialized empty Git repository in /git/git.git/t/trash directory.t9601-cvsimport-vendor-branch/module-git/.git/
    Skipping #CVSPS_NO_BRANCH
    *   ok 1: import a module with a vendor branch

    * expecting success: test_cvs_co master
    ./test-lib.sh: line 256: test_cvs_co: command not found
    * FAIL 2: check HEAD out of cvs repository
            test_cvs_co master

The reported line is where the broken test is actually "eval"ed; the 
second test tries to use the undefined test_cvs_co function.

  parent reply	other threads:[~2009-02-22 16:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-21 13:04 [PATCH v2 0/4] Add more tests of cvsimport Michael Haggerty
2009-02-21 13:04 ` [PATCH v2 1/5] Start a library for cvsimport-related tests Michael Haggerty
2009-02-21 13:04   ` [PATCH v2 2/5] Use CVS's -f option if available (ignore user's ~/.cvsrc file) Michael Haggerty
2009-02-21 13:04     ` [PATCH v2 3/5] Test contents of entire cvsimported "master" tree contents Michael Haggerty
2009-02-21 13:04       ` [PATCH v2 4/5] Add some tests of git-cvsimport's handling of vendor branches Michael Haggerty
2009-02-21 13:04         ` [PATCH v2 5/5] Add a test of "git cvsimport"'s handling of tags and branches Michael Haggerty
2009-02-22 16:49         ` Junio C Hamano [this message]
2009-02-23  5:08           ` [PATCH v3 0/5] Add more tests of cvsimport Michael Haggerty
2009-02-23  5:08             ` [PATCH v3 1/5] Start a library for cvsimport-related tests Michael Haggerty
2009-02-23  5:08               ` [PATCH v3 2/5] Use CVS's -f option if available (ignore user's ~/.cvsrc file) Michael Haggerty
2009-02-23  5:08                 ` [PATCH v3 3/5] Test contents of entire cvsimported "master" tree contents Michael Haggerty
2009-02-23  5:08                   ` [PATCH v3 4/5] Add some tests of git-cvsimport's handling of vendor branches Michael Haggerty
2009-02-23  5:08                     ` [PATCH v3 5/5] Add a test of "git cvsimport"'s handling of tags and branches Michael Haggerty
2009-02-22 16:48 ` [PATCH v2 0/4] Add more tests of cvsimport Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzlge1kob.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=mhagger@alum.mit.edu \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).