From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: jidanni@jidanni.org, git@vger.kernel.org
Subject: Re: git-format-patch patch
Date: Thu, 18 Dec 2008 00:42:43 -0800 [thread overview]
Message-ID: <7vzlitho1o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081218083515.GB29356@coredump.intra.peff.net> (Jeff King's message of "Thu, 18 Dec 2008 03:35:15 -0500")
Jeff King <peff@peff.net> writes:
> ... Besides the format not being applicable by regular git tools:
>
> - there is no commit message describing the changes, nor the reasoning
> behind them
>
> - it was not sent to the maintainer (who does read the list, but does
> not always read every message).
Actually, it would probably be a good idea not to send your first patch to
me and instead to request for comments from the list ;-)n
The worst offence of the message was the choice of bad Subject that
strongly encouraged anyone to skip it. Consider:
Subject: [PATCH] document "format-patch --in-reply-to" better
or something like that.
next prev parent reply other threads:[~2008-12-18 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 20:53 git-format-patch patch jidanni
2008-12-17 21:55 ` Miklos Vajna
2008-12-18 8:35 ` Jeff King
2008-12-18 8:42 ` Junio C Hamano [this message]
2008-12-19 19:12 ` [PATCH] Clarify git-format-patch --in-reply-to jidanni
2008-12-19 22:01 ` Bernt Hansen
2008-12-19 21:51 ` Nanako Shiraishi
2008-12-19 22:22 ` Miklos Vajna
2008-12-19 23:07 ` Junio C Hamano
2008-12-20 0:20 ` [PATCH] SubmittingPatches: mention the usage of real name in Signed-off-by: lines Miklos Vajna
2008-12-20 0:39 ` Junio C Hamano
2008-12-20 0:52 ` Miklos Vajna
2008-12-19 22:27 ` [PATCH] Clarify git-format-patch --in-reply-to jidanni
2008-12-19 22:33 ` Miklos Vajna
2008-12-19 23:20 ` just can't live without a user.name jidanni
2008-12-20 0:08 ` Miklos Vajna
2008-12-20 0:18 ` Junio C Hamano
2008-12-20 0:36 ` jidanni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzlitho1o.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jidanni@jidanni.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).