From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] git-fetch should not strip off ".git" extension Date: Mon, 20 Oct 2008 11:37:32 -0700 Message-ID: <7vzlkz2jv7.fsf@gitster.siamese.dyndns.org> References: <48FC5F1B.1050608@op5.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: SLONIK.AZ@gmail.com, git@vger.kernel.org To: Andreas Ericsson X-From: git-owner@vger.kernel.org Mon Oct 20 23:15:51 2008 connect(): Connection refused Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Krzf5-0008NT-74 for gcvg-git-2@gmane.org; Mon, 20 Oct 2008 20:39:27 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754103AbYJTShs (ORCPT ); Mon, 20 Oct 2008 14:37:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752888AbYJTShr (ORCPT ); Mon, 20 Oct 2008 14:37:47 -0400 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:39917 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752701AbYJTShr (ORCPT ); Mon, 20 Oct 2008 14:37:47 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id A8F26715A1; Mon, 20 Oct 2008 14:37:44 -0400 (EDT) Received: from pobox.com (ip68-225-240-211.oc.oc.cox.net [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTPSA id D2BAD7159E; Mon, 20 Oct 2008 14:37:39 -0400 (EDT) In-Reply-To: <48FC5F1B.1050608@op5.se> (Andreas Ericsson's message of "Mon, 20 Oct 2008 12:36:11 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 2F6C142E-9ED6-11DD-8472-9CEDC82D7133-77302942!a-sasl-fastnet.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Andreas Ericsson writes: >>... >> >> builtin-fetch--tool.c | 2 -- >> builtin-fetch.c | 2 -- >> 2 files changed, 0 insertions(+), 4 deletions(-) >> >> diff --git a/builtin-fetch--tool.c b/builtin-fetch--tool.c >> index 7460ab7..5d0b95f 100644 >> --- a/builtin-fetch--tool.c >> +++ b/builtin-fetch--tool.c >> @@ -160,8 +160,6 @@ static int append_fetch_head(FILE *fp, >> for (i = remote_len - 1; remote[i] == '/' && 0 <= i; i--) >> ; >> remote_len = i + 1; >> - if (4 < i && !strncmp(".git", remote + i - 3, 4)) >> - remote_len = i - 3; >> >> note_len = 0; >> if (*what) { >> diff --git a/builtin-fetch.c b/builtin-fetch.c >> index ee93d3a..28123a5 100644 >> --- a/builtin-fetch.c >> +++ b/builtin-fetch.c >> @@ -348,8 +348,6 @@ static int store_updated_refs(const char *url, >> const char *remote_name, >> for (i = url_len - 1; url[i] == '/' && 0 <= i; i--) >> ; >> url_len = i + 1; >> - if (4 < i && !strncmp(".git", url + i - 3, 4)) >> - url_len = i - 3; >> > > Will this still play nicely with > > git clone foo.git > > ? I think it would. As far as I can tell, the only thing the patch changes is to disable the long established "repository name clean-up" feature in the autogenerated merge messages (iow, input to "fmt-merge-msg").