git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] completion: git commit should list --interactive
@ 2008-09-11  0:40 Eric Raible
  2008-09-20  1:16 ` Shawn O. Pearce
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Raible @ 2008-09-11  0:40 UTC (permalink / raw)
  To: spearce, Git Mailing List

Signed-off-by: Eric Raible <raible@gmail.com>
---
 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/completion/git-completion.bash
b/contrib/completion/git-completion.bash
index d3fb6ae..2d8d1c3 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -750,7 +750,7 @@ _git_commit ()
 	--*)
 		__gitcomp "
 			--all --author= --signoff --verify --no-verify
-			--edit --amend --include --only
+			--edit --amend --include --only --interactive
 			"
 		return
 	esac
-- 
1.6.0.1.436.g09e16c.dirty

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] completion: git commit should list --interactive
  2008-09-11  0:40 [PATCH] completion: git commit should list --interactive Eric Raible
@ 2008-09-20  1:16 ` Shawn O. Pearce
  2008-09-20  2:44   ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn O. Pearce @ 2008-09-20  1:16 UTC (permalink / raw)
  To: Eric Raible, Junio C Hamano; +Cc: Git Mailing List

Eric Raible <raible@gmail.com> wrote:
> Signed-off-by: Eric Raible <raible@gmail.com>
> ---
>  contrib/completion/git-completion.bash |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Trivally-Acked-by: Shawn O. Pearce <spearce@spearce.org>

Sorry, got backlogged at day-job.  I'm kind of surprised this isn't
in-tree yet, its pretty simple...

> diff --git a/contrib/completion/git-completion.bash
> b/contrib/completion/git-completion.bash
> index d3fb6ae..2d8d1c3 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -750,7 +750,7 @@ _git_commit ()
>  	--*)
>  		__gitcomp "
>  			--all --author= --signoff --verify --no-verify
> -			--edit --amend --include --only
> +			--edit --amend --include --only --interactive
>  			"
>  		return
>  	esac
> -- 
> 1.6.0.1.436.g09e16c.dirty

-- 
Shawn.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] completion: git commit should list --interactive
  2008-09-20  1:16 ` Shawn O. Pearce
@ 2008-09-20  2:44   ` Junio C Hamano
  0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2008-09-20  2:44 UTC (permalink / raw)
  To: Shawn O. Pearce; +Cc: Eric Raible, Git Mailing List

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Eric Raible <raible@gmail.com> wrote:
>> Signed-off-by: Eric Raible <raible@gmail.com>
>> ---
>>  contrib/completion/git-completion.bash |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> Trivally-Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
> Sorry, got backlogged at day-job.  I'm kind of surprised this isn't
> in-tree yet, its pretty simple...

Heh, I am kind of surprised this hasn't been Acked yet.  IOW, you do not
have monopoly on getting backlogged at dayjob.

Will apply, thanks both.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-09-20  2:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-11  0:40 [PATCH] completion: git commit should list --interactive Eric Raible
2008-09-20  1:16 ` Shawn O. Pearce
2008-09-20  2:44   ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).