git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Marcus Griep <marcus@griep.us>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC Redux] strbuf: Add method to convert byte-size to human readable form
Date: Fri, 19 Sep 2008 13:32:43 -0700	[thread overview]
Message-ID: <7vzlm3ri50.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 48D3CBBA.8060507@griep.us

Marcus Griep <marcus@griep.us> writes:

> If there is no comment on this, Junio, would you be ok accepting this as
> a patch, even as a feature-branch on pu or next?

We (collectively as the development community) should be doing better than
that.  "No comment" should not mean "no objection with huge silent
support".  "No comment" simply means "no support".

If I recall correctly (I did read the patch myself when it was posted), I
did not spot anything glaringly wrong in it, but I have to go back to make
sure if we are going to queue this in 'next'.

I have deliberately been trying to keep myself from commenting on series
that I have read.  The thing is, it seems to me that that seeing my
comments on the list somehow discourages others from reviewing and
commenting, and I would really like to see people on the list to review
and help improve more patches from others.

  reply	other threads:[~2008-09-19 20:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-13  4:26 [RFC Redux] strbuf: Add method to convert byte-size to human readable form Marcus Griep
2008-09-19 15:56 ` Marcus Griep
2008-09-19 20:32   ` Junio C Hamano [this message]
2008-09-19 20:59     ` Daniel Barkalow
2008-09-19 21:55 ` Junio C Hamano
2008-09-19 22:37   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzlm3ri50.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=marcus@griep.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).