From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [RFC Redux] strbuf: Add method to convert byte-size to human readable form Date: Fri, 19 Sep 2008 13:32:43 -0700 Message-ID: <7vzlm3ri50.fsf@gitster.siamese.dyndns.org> References: <1221279997-9336-1-git-send-email-marcus@griep.us> <48D3CBBA.8060507@griep.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Git Mailing List To: Marcus Griep X-From: git-owner@vger.kernel.org Fri Sep 19 22:34:09 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kgmfv-0007eT-6r for gcvg-git-2@gmane.org; Fri, 19 Sep 2008 22:33:59 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754362AbYISUcv (ORCPT ); Fri, 19 Sep 2008 16:32:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754355AbYISUcv (ORCPT ); Fri, 19 Sep 2008 16:32:51 -0400 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:39049 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754329AbYISUcv (ORCPT ); Fri, 19 Sep 2008 16:32:51 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id EDDC3637E3; Fri, 19 Sep 2008 16:32:49 -0400 (EDT) Received: from pobox.com (ip68-225-240-211.oc.oc.cox.net [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 03D5A637DD; Fri, 19 Sep 2008 16:32:46 -0400 (EDT) User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 207C7AD0-868A-11DD-8F23-D0CFFE4BC1C1-77302942!a-sasl-fastnet.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Marcus Griep writes: > If there is no comment on this, Junio, would you be ok accepting this as > a patch, even as a feature-branch on pu or next? We (collectively as the development community) should be doing better than that. "No comment" should not mean "no objection with huge silent support". "No comment" simply means "no support". If I recall correctly (I did read the patch myself when it was posted), I did not spot anything glaringly wrong in it, but I have to go back to make sure if we are going to queue this in 'next'. I have deliberately been trying to keep myself from commenting on series that I have read. The thing is, it seems to me that that seeing my comments on the list somehow discourages others from reviewing and commenting, and I would really like to see people on the list to review and help improve more patches from others.