Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: しらいしななこ <nanako3@bluebottle.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [BUG?] "git rebase --interactive" forces me to edit message.
Date: Fri, 06 Jun 2008 16:21:48 -0700	[thread overview]
Message-ID: <7vzlpyqhdf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200806062147.m56LlCOd030269@mi0.bluebottle.com> (nanako3@bluebottle.com's message of "Sat, 07 Jun 2008 06:46:33 +0900")

しらいしななこ  <nanako3@bluebottle.com> writes:

> But I started wondering (especially after read Junio's example) if you
> might have to stop and force edit the message even for commits you
> "pick", once you have a conflict.  The patch might not conflict, but
> with your logic shouldn't you be given a chance to amend messages, now
> it was discovered that the upstream did change that overlaps what you
> did?

[jc: again, linewrap X-<]

That may be true but at that point I would have to say that people should
always examine the resulting history anyway to see if they need to fix-up
mismerges (and mismerges do happen if the reordered patches have semantic
conflicts that do not appear as textual conflicts), and re-fix the
commits, perhaps using "rebase -i" on now linearlized history.  Forcing
every single patch to be committed by hand after a single conflict is
going a bit too far, I think.

Of course, you _can_ argue that forcing the patch that conflicted to be
committed by hand even when you merely asked to 'pick', not 'edit', is
going too far by the same logic, and I tend to agree with that.  The world
is not just black and white and that case certainly feels gray.

  reply	other threads:[~2008-06-06 23:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  3:58 [BUG?] "git rebase --interactive" forces me to edit message しらいしななこ
2008-06-05  4:14 ` Junio C Hamano
2008-06-05  4:40   ` Johannes Schindelin
2008-06-05  4:38 ` Johannes Schindelin
2008-06-06 21:46   ` しらいしななこ
2008-06-06 23:21     ` Junio C Hamano [this message]
     [not found] ` <200806062147.m56LlCOe030269@mi0.bluebottle.com>
2008-06-07  4:57   ` Johannes Schindelin
2008-06-07  6:53     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzlpyqhdf.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=nanako3@bluebottle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox