From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] Fix t3701 if core.filemode disabled
Date: Thu, 22 May 2008 10:49:09 -0700 [thread overview]
Message-ID: <7vzlqiut4a.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080522132042.GF3206@steel.home> (Alex Riesen's message of "Thu, 22 May 2008 15:20:42 +0200")
Alex Riesen <raa.lkml@gmail.com> writes:
> Jeff King, Wed, May 21, 2008 16:36:07 +0200:
>> 2. It's a little hard to see which tests are affected. I would have done
>> something more like:
>>
>> if test "$(git config --bool core.filemode)" = true
>> test_filemode=
>> else
>> test_filemode=:
>> fi
>>
>> $test_filemode test_expect_success ...
>>
>> But maybe that is just overengineering.
>
> But a nice one. I like the idea but Junio already did your other
> suggestions in master, so I just keep it in mind for the next one
If you like that, I think you would like the way t0050 does even better
;-). It is Steffen Prohaska's invention, IIRC.
next prev parent reply other threads:[~2008-05-22 17:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 15:23 t3701 fails if core.filemode disabled Alex Riesen
2008-05-18 15:35 ` Johannes Schindelin
2008-05-18 17:04 ` Alex Riesen
2008-05-18 19:08 ` Jeff King
2008-05-18 20:01 ` Alex Riesen
2008-05-19 20:23 ` Alex Riesen
2008-05-19 20:55 ` Jeff King
2008-05-20 21:59 ` [PATCH] Fix t3701 " Alex Riesen
2008-05-21 14:36 ` Jeff King
2008-05-22 13:20 ` Alex Riesen
2008-05-22 17:49 ` Junio C Hamano [this message]
2008-05-22 17:55 ` Jeff King
2008-05-22 21:22 ` Alex Riesen
2008-05-19 0:17 ` t3701 fails " Mark Levedahl
2008-05-19 6:01 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzlqiut4a.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).