* [PATCH 1/1] Fix recipient santitization
@ 2008-03-28 14:09 Horst H. von Brand
2008-05-21 19:38 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Horst H. von Brand @ 2008-03-28 14:09 UTC (permalink / raw)
To: git; +Cc: Horst H. von Brand
Need to quote all special characters, not just the first one
Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
---
git-send-email.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index f62f119..3bdd225 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -635,7 +635,7 @@ sub sanitize_address
# double quotes are needed if specials or CTLs are included
elsif ($recipient_name =~ /[][()<>@,;:\\".\000-\037\177]/) {
- $recipient_name =~ s/(["\\\r])/\\$1/;
+ $recipient_name =~ s/(["\\\r])/\\$1/g;
$recipient_name = "\"$recipient_name\"";
}
--
1.5.5.rc2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] Fix recipient santitization
2008-03-28 14:09 [PATCH 1/1] Fix recipient santitization Horst H. von Brand
@ 2008-05-21 19:38 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2008-05-21 19:38 UTC (permalink / raw)
To: git; +Cc: Horst H. von Brand
Last night I was going through old mail-logs and found this, which I think
still is needed. Does anybody see anything wrong with the patch (aside
from missing full-stop at the end of the sentence)?
"Horst H. von Brand" <vonbrand@inf.utfsm.cl> writes:
> Need to quote all special characters, not just the first one
>
> Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
> ---
> git-send-email.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index f62f119..3bdd225 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -635,7 +635,7 @@ sub sanitize_address
>
> # double quotes are needed if specials or CTLs are included
> elsif ($recipient_name =~ /[][()<>@,;:\\".\000-\037\177]/) {
> - $recipient_name =~ s/(["\\\r])/\\$1/;
> + $recipient_name =~ s/(["\\\r])/\\$1/g;
> $recipient_name = "\"$recipient_name\"";
> }
>
> --
> 1.5.5.rc2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-21 19:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-28 14:09 [PATCH 1/1] Fix recipient santitization Horst H. von Brand
2008-05-21 19:38 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).