Re: What's not in 'master' but should be

[Junio C Hamano <gitster@pobox.com>]

"Lars Hjemli" <hjemli@gmail.com> writes:

> Hmm, isn't a nonfunctional libgit considered breakage? Without
> something like this patch it is no longer possible to use
> write_tar_archive()/write_zip_archive() in libgit.a.

Sorry, but libgit.a is not part of what we deliver.  We do not
support linking random stuff against libgit.a.  We never did.
It is not a "library".

It has always been just an implementation detail for us to be
lax about our Makefile, so that we do not have to write down
exactly which *.o files git-foo command depended upon (and it is
ceasing to be useful for that as very many things have moved to
"the single git binary" these days).  Instead we let the linker
pick out the necessary pieces out of the archive.

So, no, there is no breakage.

The code movement you did _should_ not hurt so it may be a fine
material for post 1.5.4, but I haven't carefully compared what
other change might have accidentally snuck in that patch, and I
would rather not have to during the rc cycle.