git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Imran M Yousuf" <imyousuf@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] - Updated usage and simplified sub-command action invocation
Date: Wed, 09 Jan 2008 23:22:54 -0800	[thread overview]
Message-ID: <7vzlve6t69.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7bfdc29a0801092251p3d46a3cau3db4d57c4f705043@mail.gmail.com> (Imran M. Yousuf's message of "Thu, 10 Jan 2008 12:51:42 +0600")

"Imran M Yousuf" <imyousuf@gmail.com> writes:

> On Jan 10, 2008 12:23 PM, Junio C Hamano <gitster@pobox.com> wrote:
> ...
>> I somehow feel that syntactically the original implementation
>> that allowed subcommand specific options to come before the
>> subcommand name was a mistake.  It may be easier for users that
>> both "-b branch add" and "add -b branch" are accepted, but I
>> have to wonder if it would really hurt if we made "-b branch
>> add" a syntax error.
>
> I will recode it to have all options except for --quiet (which is
> inverse of -v or --verbose) be mentioned after the subcommand.

Just a word of caution when dealing with me.

Unlike Linus, I am not always right.  And other people on the
list who are here longer already know this. I am reasonably sure
that some of them will disagree with me on design issues like
this one; I mildly suspect that this forbidding "-b branch add"
might be met with resistance from existing users.

You do not have to agree with me on every little detail I
mention.  If you feel a design issue might be contentious, it
could turn out to be a better use of your time to keep the code
as it is while waiting to see if other people would offer better
alternatives.

> Actually module_$command is not possible because only add's module is
> module_add rest are modules_$command....

Is there a fundamental reason why you cannot rename them to be
more consistent?

  reply	other threads:[~2008-01-10  7:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10  4:07 [PATCH] - Updated usage and simplified sub-command action invocation imyousuf
2008-01-10  6:23 ` Junio C Hamano
2008-01-10  6:51   ` Imran M Yousuf
2008-01-10  7:22     ` Junio C Hamano [this message]
2008-01-10  7:41       ` Imran M Yousuf
2008-01-12  1:38         ` Junio C Hamano
2008-01-11  9:09   ` Imran M Yousuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzlve6t69.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=imyousuf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).