From: Junio C Hamano <gitster@pobox.com>
To: Jim Meyering <jim@meyering.net>
Cc: git@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: (resend) [PATCH] Don't ignore write failure from git-diff, git-log, etc.
Date: Sun, 24 Jun 2007 02:01:59 -0700 [thread overview]
Message-ID: <7vzm2pwws8.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <87abuq1z6f.fsf@rho.meyering.net> (Jim Meyering's message of "Sat, 23 Jun 2007 17:13:44 +0200")
Jim Meyering <jim@meyering.net> writes:
> From: Jim Meyering <jim@meyering.net>
> Date: Sat, 26 May 2007 13:43:07 +0200
> Subject: [PATCH] Don't ignore write failure from git-diff, git-log, etc.
>
> Currently, when git-diff writes to a full device or gets an I/O error,
> it fails to detect the write error:
> ...
> Also, to be consistent with e.g., write_or_die, do not
> diagnose EPIPE write failures.
I still do not like the fact that this patch makes an error from
the final stdout flushing override the return value from p->fn()
even when the function already diagnosed an error, but otherwise
I think it is a good change, as it allows us to catch one error
case that we currently don't, without introducing an annoying
EPIPE diagnosis.
Naks, or vetoes?
next prev parent reply other threads:[~2007-06-24 9:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-23 15:13 (resend) [PATCH] Don't ignore write failure from git-diff, git-log, etc Jim Meyering
2007-06-24 9:01 ` Junio C Hamano [this message]
2007-06-24 17:08 ` Linus Torvalds
2007-06-24 17:10 ` [PATCH 1/2] Clean up internal command handling Linus Torvalds
2007-06-24 17:29 ` [PATCH 2/2] Check for IO errors after running a command Linus Torvalds
2007-06-25 9:44 ` Junio C Hamano
2007-06-25 13:20 ` Johannes Schindelin
2007-06-25 13:42 ` Johannes Sixt
2007-06-25 14:01 ` Jim Meyering
2007-06-25 15:57 ` Linus Torvalds
2007-06-26 13:33 ` Matthias Lederhofer
2007-06-25 19:54 ` Jim Meyering
2007-06-24 19:13 ` (resend) [PATCH] Don't ignore write failure from git-diff, git-log, etc Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzm2pwws8.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).