From: Junio C Hamano <junkio@cox.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] diff.c: second war on whitespace.
Date: Sat, 23 Sep 2006 02:37:37 -0700 [thread overview]
Message-ID: <7vzmcqudni.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <ef2u05$f29$1@sea.gmane.org> (Jakub Narebski's message of "Sat, 23 Sep 2006 11:15:53 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> Junio C Hamano wrote:
>
>> gmane.comp.version-control.git
>> This adds DIFF_WHITESPACE color class (default = reverse red) to
>> colored diff output to let you catch common whitespace errors.
>>
>> - trailing whitespaces at the end of line
>> - a space followed by a tab in the indent
>
> In gitweb/gitweb.perl, around %feature hash definition, we have:
>
> <TAB> # <SP> <TAB> 'sub' ...
>
> and I think that is exception to the "no space followed by tab" rule.
Read the description again. No space IN INDENT that is followed
by tab.
prev parent reply other threads:[~2006-09-23 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 7:47 [PATCH 1/2] diff.c: second war on whitespace Junio C Hamano
2006-09-23 9:15 ` Jakub Narebski
2006-09-23 9:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzmcqudni.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox