From: Junio C Hamano <junkio@cox.net>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: diff machinery cleanup
Date: Thu, 10 Aug 2006 10:06:42 -0700 [thread overview]
Message-ID: <7vzmecv7tp.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060810103836.GA1317@coredump.intra.peff.net> (Jeff King's message of "Thu, 10 Aug 2006 06:38:37 -0400")
Jeff King <peff@peff.net> writes:
> OK, doing a discard_cache() between the call to run_diff_index and
> run_diff_files seems to clear up the problem. But if I understand
> correctly, are you saying that run_diff_index has munged the index on
> disk, and I really need to be poking at a temporary copy? If so, why
> isn't that a problem when running (e.g.) "git-diff-index; git-ls-files"?
No, run_diff_index munges the index in-core, and it does not
writes it out for obvious reasons.
Some of the "interrogation commands" do munge the index without
writing it out because that is the easiest/cleanest way to
implement what they do. ls-files does it to filter by paths,
for example.
> That does sound the cleanest, and it would enable a more useful status
> message, as you mentioned before. What caused you to stop working on it?
> Infeasible, or simply more infeasible than you would like right now?
Finding out somebody was already working on it?
next prev parent reply other threads:[~2006-08-10 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 8:24 diff machinery cleanup Jeff King
2006-08-10 9:36 ` Junio C Hamano
2006-08-10 10:38 ` Jeff King
2006-08-10 17:06 ` Junio C Hamano [this message]
2006-08-10 20:10 ` Jeff King
2006-08-10 21:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzmecv7tp.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).