From: Junio C Hamano <junkio@cox.net>
To: Pavel Roskin <proski@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Avoid C++ comments, use C comments instead
Date: Mon, 10 Jul 2006 00:46:28 -0700 [thread overview]
Message-ID: <7vzmfhdhrf.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060710065751.22902.43316.stgit@dv.roinet.com> (Pavel Roskin's message of "Mon, 10 Jul 2006 02:57:51 -0400")
Pavel Roskin <proski@gnu.org> writes:
> From: Pavel Roskin <proski@gnu.org>
>
> This doesn't make the code uglier or harder to read, yet it makes the
> code more portable. This also simplifies checking for other potential
> incompatibilities. "gcc -std=c89 -pedantic" can flag many incompatible
> constructs as warnings, but C++ comments will cause it to emit an error.
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
The title should probably read "avoid C99 comments", but coming
from the previous century, I tend to agree with this.
The struct/array initializer stuff by Shawn makes them harder to
read (for structs, it moves initialization to actual code) and
more error prone (for arrays, now the initializers need to be
carefully kept ordered), but we do not have too many of them in
the code, so I do not think it is a not much of a practical
problem. It is sad that some people stay behind and we need to
cater to them, though.
next prev parent reply other threads:[~2006-07-10 7:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 6:57 [PATCH] Avoid C++ comments, use C comments instead Pavel Roskin
2006-07-10 7:46 ` Junio C Hamano [this message]
2006-07-10 9:46 ` Olivier Galibert
2006-07-10 11:06 ` Johannes Schindelin
2006-07-10 11:41 ` Olivier Galibert
2006-07-10 19:14 ` Paul Serice
2006-07-10 20:24 ` Olivier Galibert
2006-07-10 22:55 ` Johannes Schindelin
2006-07-10 23:25 ` Yakov Lerner
2006-07-10 23:51 ` Olivier Galibert
2006-07-11 0:15 ` Shawn Pearce
2006-07-11 0:34 ` Junio C Hamano
2006-07-10 23:42 ` Olivier Galibert
2006-07-11 5:17 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzmfhdhrf.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).