From: Junio C Hamano <junkio@cox.net>
To: "Yakov Lerner" <iler.ml@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: (patch) calloc->xcalloc in read-cache.c
Date: Mon, 08 May 2006 13:54:50 -0700 [thread overview]
Message-ID: <7vzmhsdyp1.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <f36b08ee0605081101w3dc3a60cof5a524e9b4a3f555@mail.gmail.com> (Yakov Lerner's message of "Mon, 8 May 2006 21:01:40 +0300")
"Yakov Lerner" <iler.ml@gmail.com> writes:
> --- read-cache.c.000 2006-05-08 15:13:57.000000000 +0000
> +++ read-cache.c 2006-05-08 15:15:35.000000000 +0000
> @@ -557,7 +557,7 @@
>
> active_nr = ntohl(hdr->hdr_entries);
> active_alloc = alloc_nr(active_nr);
> - active_cache = calloc(active_alloc, sizeof(struct cache_entry *));
> + active_cache = xcalloc(active_alloc, sizeof(struct cache_entry *));
>
> offset = sizeof(*hdr);
> for (i = 0; i < active_nr; i++) {
>
> Yakov
While I do not mind hand generated patch, your mailer setting
seems to be seriously broken.
Mind checking Documentation/SubmittingPatches and try again?
prev parent reply other threads:[~2006-05-08 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-08 18:01 (patch) calloc->xcalloc in read-cache.c Yakov Lerner
2006-05-08 20:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzmhsdyp1.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=iler.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox