Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Martin Langhoff <martin.langhoff@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: cg-clone, tag objects and cg-push/git-push don't play nice
Date: Wed, 19 Oct 2005 00:16:37 -0700	[thread overview]
Message-ID: <7vzmp6dlii.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <46a038f90510182338k6d3d52fbyc2057e9b775d5b14@mail.gmail.com> (Martin Langhoff's message of "Wed, 19 Oct 2005 19:38:16 +1300")

Martin Langhoff <martin.langhoff@gmail.com> writes:

>  + git-push is trying to walk all the refs it knows about when it does
> the "what do I have that the repo doesn't" part, and it breaks on
> those incomplete tag fetches.

That is expected.

> Removing  .git/refs/tags/* didn't help. If I actually rm all the
> problematic tag objects from the object repository, I can then push
> correctly. Lucky it wasn't packed.
>
> I am going to write a quick'n'dirty script to fix our repos when this
> happens, and I'll try my hand at a patch to cg-fetch. Can git-push be
> taught to be smarter in these cases?

Although I do not follow Cogito development closely, I seem to
recall that it fetched tags without making them complete at some
point in the past; I hope it is now fixed but I am not sure.

I cannot think offhand of a way how git-push could help to cope
with a repository broken that way.  However, we could probably
have a tool that tangles from each ref, find incomplete ones and
remove them from .git/refs.  After running that maybe pull from
a know good copy would fix the broken repository.

I do not understand why removing .git/refs/tags/* did not help,
and that is the biggest thing that disturbs me in this whole
problem report.  We (meaning git-* transfer, not cg-* transfer
whose correctness I cannot vouch for) _should_ be relying only
on refs not object existence.  Maybe there are some other files
under .git/refs/ directory that had copies of them?

  reply	other threads:[~2005-10-19  7:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-19  6:38 cg-clone, tag objects and cg-push/git-push don't play nice Martin Langhoff
2005-10-19  7:16 ` Junio C Hamano [this message]
2005-10-19  8:10   ` Martin Langhoff
2005-10-19  8:52     ` Junio C Hamano
2005-10-19  9:06       ` Martin Langhoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzmp6dlii.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=martin.langhoff@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox