From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: [PATCH (take 2)] diff-cache.c compilation warning fix.
Date: Wed, 27 Apr 2005 21:59:55 -0700 [thread overview]
Message-ID: <7vzmvja438.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vekcvbkq8.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Wed, 27 Apr 2005 21:15:11 -0700")
Nobody uses return value from show_new_file() function but it is
defined as returning int and falls off at the end without
returning. Make it void.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
This is take 2. Earlier one was a botched patch that left
"return -1" in the function.
diff-cache.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
# - [PATCH] diff-tree -p implies diff-tree -p -r
# + 04/27 21:50 diff.c clean up temporary file.
--- k/diff-cache.c
+++ l/diff-cache.c
@@ -38,14 +38,14 @@ static int get_stat_data(struct cache_en
return 0;
}
-static int show_new_file(struct cache_entry *new)
+static void show_new_file(struct cache_entry *new)
{
unsigned char *sha1;
unsigned int mode;
/* New file in the index: it might actually be different in the working copy */
if (get_stat_data(new, &sha1, &mode) < 0)
- return -1;
+ return;
show_file("+", new, sha1, mode);
}
prev parent reply other threads:[~2005-04-28 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-28 4:15 [PATCH] diff-cache.c compilation warning fix Junio C Hamano
2005-04-28 4:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzmvja438.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox