From: Bruce Stephens <bruce.stephens@isode.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org
Subject: Re: Odd .gitignore behaviour
Date: Thu, 15 Nov 2007 20:15:19 +0000 [thread overview]
Message-ID: <80ir43e04o.fsf@tiny.isode.net> (raw)
In-Reply-To: <alpine.LFD.0.9999.0711151044150.2786@woody.linux-foundation.org> (Linus Torvalds's message of "Thu\, 15 Nov 2007 10\:56\:27 -0800 \(PST\)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
[...]
> So what you describe sounds wrong.
>
> But my quick test didn't actually support the behaviour you see. In this
> situation:
>
> [torvalds@woody git-test]$ cat .gitignore
> a*
> [torvalds@woody git-test]$ cat subdir/.gitignore
> !a-ok
> [torvalds@woody git-test]$ find *
> all-files
> subdir
> subdir/a-ok
> [torvalds@woody git-test]$ git ls-files -o --exclude-per-directory=.gitignore
> .gitignore
> subdir/.gitignore
> subdir/a-ok
>
> ie we *do* show "showdir/a-ok" (but we don't show "all-files") because
> a-ok is explicitly marked to be not ignored by a higher-priority rule.
OK, and if I say "git add subdir/a-ok" I get no error, as expected.
So extend it just a tiny bit, moving a-ok down a directory and using
the negative pattern "!subsubdir/a-ok" to match:
brs% cat .gitignore
a*
brs% cat subdir/.gitignore
!subsubdir/a-ok
brs% find *
all-files
subdir
subdir/.gitignore
subdir/subsubdir
subdir/subsubdir/a-ok
subdir/a-ok
brs% git ls-files -o --exclude-per-directory=.gitignore
.gitignore
subdir/.gitignore
subdir/subsubdir/a-ok
brs% git add subdir/subsubdir/a-ok
The following paths are ignored by one of your .gitignore files:
subdir/subsubdir/a-ok
Use -f if you really want to add them.
fatal: no files added
So I think the output from git-ls-files is as expected (as I interpret
the manpage and your explanation). So is git-add just using some
different code?
[...]
next prev parent reply other threads:[~2007-11-15 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 12:49 Odd .gitignore behaviour Bruce Stephens
2007-11-15 18:56 ` Linus Torvalds
2007-11-15 20:15 ` Bruce Stephens [this message]
2007-11-15 21:51 ` Junio C Hamano
2007-11-15 22:13 ` Junio C Hamano
2007-11-16 9:15 ` Fix per-directory exclude handing for "git add" Junio C Hamano
2007-11-16 13:50 ` Bruce Stephens
2007-11-16 15:05 ` Bruce Stephens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ir43e04o.fsf@tiny.isode.net \
--to=bruce.stephens@isode.com \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).