git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Stephens <bruce.stephens@isode.com>
To: Dominik Gront <dgront@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Can I enforce required approval on some files
Date: Tue, 20 Jul 2010 21:45:01 +0100	[thread overview]
Message-ID: <80pqyhc27m.fsf@tiny.isode.net> (raw)
In-Reply-To: <AANLkTinQI9eBnwjzPhYHMM8XZ0ODfHJ1qiZJrNWQWUno@mail.gmail.com> (Dominik Gront's message of "Tue, 20 Jul 2010 13:22:10 -0700")

Dominik Gront <dgront@gmail.com> writes:

> I have been a happy SVN user for quite a long time, but now I miss
> some functionality in Subversion. I wonder if it could be done in git.
> If so, I convert to git right away :-)
>
> There are some files in our repository that all their modification
> need to be approved by a project leader.

Either have the repository owned by someone who'll do whatever checking
you want (which seems to be common at least amongst the public projects)
or use hooks in a shared repository.  Specifically the update hook.

The hook can do whatever checking you deem appropriate.  At work we have
it check the commit message for Signed-off-by names (in our context it
really means Reviewed-by; we use sob because that's more convenient to
add).  The hook could look at which files are changed or whatever else
you wanted.  (Notice it gets called to update a ref, and that may
involve more than one commit, so be sure to check all the relevant
commits.)

[...]

  reply	other threads:[~2010-07-20 20:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-20 20:22 Can I enforce required approval on some files Dominik Gront
2010-07-20 20:45 ` Bruce Stephens [this message]
2010-07-20 20:45 ` Sylvain Rabot
2010-07-20 22:03 ` Jakub Narebski
2010-07-21  0:42   ` Ævar Arnfjörð Bjarmason
2010-07-21  7:51     ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80pqyhc27m.fsf@tiny.isode.net \
    --to=bruce.stephens@isode.com \
    --cc=dgront@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).