git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Stephens <bruce.stephens@isode.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, git@vger.kernel.org
Subject: Re: Fix per-directory exclude handing for "git add"
Date: Fri, 16 Nov 2007 13:50:29 +0000	[thread overview]
Message-ID: <80y7cy2tay.fsf@tiny.isode.net> (raw)
In-Reply-To: <7vodduzh36.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Fri\, 16 Nov 2007 01\:15\:41 -0800")

Junio C Hamano <gitster@pobox.com> writes:

[...]

> While read_directory_recursive() runs, calls to excluded() makes use
> the data in the exclusion elements, including this base string.  The
> caller of read_directory_recursive() is not supposed to free the
> buffer it gave to push_exclude_per_directory() earlier, until it
> returns.

Cool, that fixes the "git add" issue I was seeing.  (So Acked-by:
Bruce Stephens <bruce.stephens@isode.com>, for what it's worth.)

I guess really the output of "git status" (or "git runstatus") is more
significant since that's what we'd normally be running (that's
presumably what "git gui" and similar tools run, though perhaps they
use "git ls-files"---probably the underlying code's the same, I
guess).

However, that doesn't mean the issue with git add shouldn't be
resolved.

[...]

  reply	other threads:[~2007-11-16 13:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-15 12:49 Odd .gitignore behaviour Bruce Stephens
2007-11-15 18:56 ` Linus Torvalds
2007-11-15 20:15   ` Bruce Stephens
2007-11-15 21:51     ` Junio C Hamano
2007-11-15 22:13       ` Junio C Hamano
2007-11-16  9:15       ` Fix per-directory exclude handing for "git add" Junio C Hamano
2007-11-16 13:50         ` Bruce Stephens [this message]
2007-11-16 15:05           ` Bruce Stephens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80y7cy2tay.fsf@tiny.isode.net \
    --to=bruce.stephens@isode.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).