Git development
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>
Subject: [PATCH] hold_index_file_for_update should not unlink failed to open .lock files atexit
Date: Wed, 5 Oct 2005 16:58:11 +0200	[thread overview]
Message-ID: <81b0412b0510050758v26b88f4o5f15e3ff01e9cd87@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hello,

I noticed that index.lock is one time removed by git-update-index
and the other time not (I am still trying to make the rename behave on
my cygwin installation). The atexit callback removes .lock file uncoditionally,
whether it was opened by the current process or not.

I fixed this with the attached (sorry, it's windows+firefox+gmail) patch.

The patch sets up atexit only if the file was opened successfully.

[-- Attachment #2: hold_index_file_for_update.patch --]
[-- Type: application/xxxxx, Size: 787 bytes --]

             reply	other threads:[~2005-10-05 14:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-05 14:58 Alex Riesen [this message]
2005-10-05 18:49 ` [PATCH] hold_index_file_for_update should not unlink failed to open .lock files atexit Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0510050758v26b88f4o5f15e3ff01e9cd87@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox