From: "Alex Riesen" <raa.lkml@gmail.com>
To: "David Rientjes" <rientjes@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] introduce inline is_same_sha1
Date: Thu, 17 Aug 2006 13:59:02 +0200 [thread overview]
Message-ID: <81b0412b0608170459if099fcane9d9e91a3fdac9e6@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0608161721020.11465@chino.corp.google.com>
On 8/17/06, David Rientjes <rientjes@google.com> wrote:
> Introduces global inline:
> is_same_sha1(const unsigned char *sha1,
> const unsigned char *sha2);
It is longer and negates all (like in "lots") previous callsites of memcmp.
Are sure you didn't do a trivial typo somewhere?
Why not just sha1cmp? And if you're aiming at hash-type independence,
why not hashcmp?
next prev parent reply other threads:[~2006-08-17 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 0:25 [PATCH] introduce inline is_same_sha1 David Rientjes
2006-08-17 1:12 ` Junio C Hamano
2006-08-17 3:51 ` David Rientjes
2006-08-17 6:26 ` Junio C Hamano
2006-08-17 11:59 ` Alex Riesen [this message]
2006-08-17 18:54 ` David Rientjes
2006-08-17 20:50 ` Alex Riesen
2006-08-18 4:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0608170459if099fcane9d9e91a3fdac9e6@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).