git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: "Randal L. Schwartz" <merlyn@stonehenge.com>,
	git@vger.kernel.org, "Brian Gernhardt" <benji@silverinsanity.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	Pazu <pazu@pazu.com.br>, "Andreas Ericsson" <ae@op5.se>
Subject: Re: Commit f84871 breaks build on OS X
Date: Fri, 8 Dec 2006 08:40:42 +0100	[thread overview]
Message-ID: <81b0412b0612072340w6af9df37y25a1d15773a3f8d8@mail.gmail.com> (raw)
In-Reply-To: <7virgnqpt5.fsf@assigned-by-dhcp.cox.net>

On 12/7/06, Junio C Hamano <junkio@cox.net> wrote:
> >> Definitely something went weird when Makefile was removed
> >> from .gitignore.
> >
> > Yes, perl/Makefile is getting overwritten by what Makefile.PL
> > generates.  I thought the point of Alex's patch was to have it
> > muck with perl.mak and leave the tracked Makefile alone?
>
> Now, I am CLUELESS about what MakeMaker does, but would this
> help?
>

Much better.
Works here. Others?

> diff --git a/perl/Makefile.PL b/perl/Makefile.PL
> index de73235..4168775 100644
> --- a/perl/Makefile.PL
> +++ b/perl/Makefile.PL
> @@ -24,5 +24,6 @@ WriteMakefile(
>  	NAME            => 'Git',
>  	VERSION_FROM    => 'Git.pm',
>  	PM		=> \%pm,
> +	MAKEFILE	=> 'perl.mak',
>  	%extra
>  );

I should have read the FS of that MakeMaker.pm,

  reply	other threads:[~2006-12-08  7:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07 13:54 Commit f84871 breaks build on OS X Brian Gernhardt
2006-12-07 14:33 ` Alex Riesen
2006-12-07 15:20   ` Pazu
2006-12-07 20:18   ` Randal L. Schwartz
2006-12-07 22:36     ` Junio C Hamano
2006-12-07 22:55       ` Junio C Hamano
2006-12-08  7:40         ` Alex Riesen [this message]
2006-12-08 11:51           ` Brian Gernhardt
2006-12-07 14:55 ` Johannes Schindelin
2006-12-07 15:23   ` Andreas Ericsson
2006-12-07 15:29   ` Brian Gernhardt
2006-12-07 15:42     ` Alex Riesen
  -- strict thread matches above, loose matches on Subject: below --
2006-12-07 16:04 Brian Gernhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0612072340w6af9df37y25a1d15773a3f8d8@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=ae@op5.se \
    --cc=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=merlyn@stonehenge.com \
    --cc=pazu@pazu.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).