git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <junkio@cox.net>
Subject: [PATCH] Avoid ActiveState Perl IO in t800[12]
Date: Mon, 5 Feb 2007 14:15:14 +0100	[thread overview]
Message-ID: <81b0412b0702050515s7e0efe3fm76220a6c647dbee@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

Use sed instead, it comes with cygwin and there is almost no chance of
someone installing a sed with default CRLF lineendings by accident.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

I have been seeing failures in the t800x tests from the beginning on, I
believe. Today they annoyed me enough to get them fixed.
The reason of the failures is the usual one: for reasons unexplainable
activestate perl defaults to CRLF lineendings in all output, which in the
testcase changes the whole file.

 t/annotate-tests.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

[-- Attachment #2: 0001-Avoid-ActiveState-Perl-IO-in-t800-12.txt --]
[-- Type: text/plain, Size: 1253 bytes --]

From c242c7ea07d98ddfb45961b52f5975d0297f9781 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Mon, 5 Feb 2007 14:04:09 +0100
Subject: [PATCH] Avoid ActiveState Perl IO in t800[12]

Use sed instead, it comes with cygwin and there is almost no chance of
someone installing a sed with default CRLF lineendings by accident.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

I have been seeing failures in the t800x tests from the beginning on, I
believe. Today they annoyed me enough to get them fixed.
The reason of the failures is the usual one: for reasons unexplainable
activestate perl defaults to CRLF lineendings in all output, which in the
testcase changes the whole file.

 t/annotate-tests.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
index b5ceba4..87403da 100644
--- a/t/annotate-tests.sh
+++ b/t/annotate-tests.sh
@@ -113,7 +113,8 @@ test_expect_success \
 
 test_expect_success \
     'some edit' \
-    'perl -p -i.orig -e "s/^1A.*\n$//; s/^3A/99/" file &&
+    'mv file file.orig &&
+    sed -e "s/^3A/99/" -e "/^1A/d" < file.orig > file &&
     GIT_AUTHOR_NAME="D" git commit -a -m "edit"'
 
 test_expect_success \
-- 
1.5.0.rc3.72.g4005


                 reply	other threads:[~2007-02-05 13:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0702050515s7e0efe3fm76220a6c647dbee@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).