* [PATCH] Fix passing of TCLTK_PATH to git-gui
@ 2007-04-05 7:49 Alex Riesen
2007-04-05 8:44 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Alex Riesen @ 2007-04-05 7:49 UTC (permalink / raw)
To: Git Mailing List; +Cc: Junio C Hamano, Eygene Ryabinkin
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
GNU make does not include environment variables by default
in its namespace.
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
[-- Attachment #2: 0001-Fix-passing-of-TCLTK_PATH-to-git-gui.txt --]
[-- Type: text/plain, Size: 791 bytes --]
From 1df61a9f1f3551eaad699ce1c4ef4ada734c9836 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 5 Apr 2007 09:45:03 +0200
Subject: [PATCH] Fix passing of TCLTK_PATH to git-gui
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index ad321b3..507ad91 100644
--- a/Makefile
+++ b/Makefile
@@ -703,7 +703,7 @@ endif
all::
ifndef NO_TCLTK
- $(QUIET_SUBDIR0)git-gui TCLTK_PATH='$(TCLTK_PATH_SQ)' $(QUIET_SUBDIR1) all
+ $(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) TCLTK_PATH='$(TCLTK_PATH_SQ)' all
endif
$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all
$(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1)
--
1.5.1.41.g3ea92
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix passing of TCLTK_PATH to git-gui
2007-04-05 7:49 [PATCH] Fix passing of TCLTK_PATH to git-gui Alex Riesen
@ 2007-04-05 8:44 ` Junio C Hamano
2007-04-05 13:10 ` Alex Riesen
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2007-04-05 8:44 UTC (permalink / raw)
To: Alex Riesen; +Cc: Git Mailing List, Eygene Ryabinkin
"Alex Riesen" <raa.lkml@gmail.com> writes:
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>
> GNU make does not include environment variables by default
> in its namespace.
Shouldn't this be part of proposed commit log message?
Also I'd appreciate if you did not attach the format-patch
output, but send a properly formatted e-mail. I would not be so
picky to non-regulars, but I expect I'd be getting many more
patches from you, so...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix passing of TCLTK_PATH to git-gui
2007-04-05 8:44 ` Junio C Hamano
@ 2007-04-05 13:10 ` Alex Riesen
2007-04-05 19:31 ` Alex Riesen
0 siblings, 1 reply; 4+ messages in thread
From: Alex Riesen @ 2007-04-05 13:10 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List, Eygene Ryabinkin
On 4/5/07, Junio C Hamano <junkio@cox.net> wrote:
> "Alex Riesen" <raa.lkml@gmail.com> writes:
>
> > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> > ---
> >
> > GNU make does not include environment variables by default
> > in its namespace.
>
> Shouldn't this be part of proposed commit log message?
Err... yes.
> Also I'd appreciate if you did not attach the format-patch
> output, but send a properly formatted e-mail. I would not be so
> picky to non-regulars, but I expect I'd be getting many more
> patches from you, so...
I'll resend as soon as I get home.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Fix passing of TCLTK_PATH to git-gui
2007-04-05 13:10 ` Alex Riesen
@ 2007-04-05 19:31 ` Alex Riesen
0 siblings, 0 replies; 4+ messages in thread
From: Alex Riesen @ 2007-04-05 19:31 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List, Eygene Ryabinkin
GNU make does not include environment variables by default
in its namespace. Just pass them in make command line.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index ad321b3..507ad91 100644
--- a/Makefile
+++ b/Makefile
@@ -703,7 +703,7 @@ endif
all::
ifndef NO_TCLTK
- $(QUIET_SUBDIR0)git-gui TCLTK_PATH='$(TCLTK_PATH_SQ)' $(QUIET_SUBDIR1) all
+ $(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) TCLTK_PATH='$(TCLTK_PATH_SQ)' all
endif
$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all
$(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1)
--
1.5.1.rc3.48.g803f1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-04-05 19:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-05 7:49 [PATCH] Fix passing of TCLTK_PATH to git-gui Alex Riesen
2007-04-05 8:44 ` Junio C Hamano
2007-04-05 13:10 ` Alex Riesen
2007-04-05 19:31 ` Alex Riesen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).