From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Eygene Ryabinkin" <rea-git@codelabs.ru>
Subject: Re: [PATCH] Fix passing of TCLTK_PATH to git-gui
Date: Thu, 5 Apr 2007 15:10:25 +0200 [thread overview]
Message-ID: <81b0412b0704050610m19a72984u34888af00d70eeab@mail.gmail.com> (raw)
In-Reply-To: <7v8xd7tdl0.fsf@assigned-by-dhcp.cox.net>
On 4/5/07, Junio C Hamano <junkio@cox.net> wrote:
> "Alex Riesen" <raa.lkml@gmail.com> writes:
>
> > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> > ---
> >
> > GNU make does not include environment variables by default
> > in its namespace.
>
> Shouldn't this be part of proposed commit log message?
Err... yes.
> Also I'd appreciate if you did not attach the format-patch
> output, but send a properly formatted e-mail. I would not be so
> picky to non-regulars, but I expect I'd be getting many more
> patches from you, so...
I'll resend as soon as I get home.
next prev parent reply other threads:[~2007-04-05 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 7:49 [PATCH] Fix passing of TCLTK_PATH to git-gui Alex Riesen
2007-04-05 8:44 ` Junio C Hamano
2007-04-05 13:10 ` Alex Riesen [this message]
2007-04-05 19:31 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0704050610m19a72984u34888af00d70eeab@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=rea-git@codelabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).