From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org, "Junio C Hamano" <junkio@cox.net>
Subject: Re: [PATCH] Fix merge-recursive on cygwin: broken errno when unlinking a directory
Date: Thu, 19 Apr 2007 10:28:44 +0200 [thread overview]
Message-ID: <81b0412b0704190128o7fccbe77h8df3114328d6a0da@mail.gmail.com> (raw)
In-Reply-To: <20070418234034.GE2477@steel.home>
On 4/19/07, Alex Riesen <raa.lkml@gmail.com> wrote:
> >
> > So here's a suggested and totally untested patch. It makes the code more
> > readable, and probably fixes *two* bugs in the process. It also simply
> > doesn't really even care what the error actually was - the important part
> > was not that it was a directory, but that the unlink didn't succeed!
> >
>
> Well, it is a bit tested now. I'll repeat the testing tomorrow on that
> windows box.
>
Tested on windows too. Works.
next prev parent reply other threads:[~2007-04-19 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-18 22:33 [PATCH] Fix merge-recursive on cygwin: broken errno when unlinking a directory Alex Riesen
2007-04-18 23:04 ` Linus Torvalds
2007-04-18 23:40 ` Alex Riesen
2007-04-19 8:28 ` Alex Riesen [this message]
2007-04-19 16:39 ` Linus Torvalds
2007-04-19 18:31 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0704190128o7fccbe77h8df3114328d6a0da@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).