git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Dana How" <danahow@gmail.com>
Cc: "Junio C Hamano" <junkio@cox.net>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Support ent:relative_path
Date: Fri, 4 May 2007 11:17:12 +0200	[thread overview]
Message-ID: <81b0412b0705040217o54d1d028j6e768bdc3eb0bad0@mail.gmail.com> (raw)
In-Reply-To: <56b7f5510705040153i65ba6260v9fbe7a90e040cab3@mail.gmail.com>

On 5/4/07, Dana How <danahow@gmail.com> wrote:
> > >  (1) we say it was a mistake that we did not make it relative to
> > >      the current directory when we introduced the X:<path>
> > >      syntax (X could be empty or :[0-3]: for index, or a commit
> > >      or tree object name), and change the semantics in a future
> > >      major release for everybody, apologizing for potentially
> > >      breaking existing scripts; or
> >
> > That would be my first prio preference
>
> Mine too,  but I don't want to break anything.

It probably wont break anything which is not already broken.
It's somehow hard to imagine someone would use the
syntax to check for absence of a file in non-top-level
subdirectory. Besides, the existing syntax is ambiguous:
for anyone using pathname tab completion.

Besides, you can give a warning of ambiguity in case there are
equal relative and a top-level paths. Return the relative, but print
the warning, so people can fix their scripts.

> > > My preference is (2), (3) and then (1), but I do not have
> > > offhand a suggestion for a good metacharacter we could use.
> >
> > "./" :)
> Heh.  Yes, that works in the current patch.
>
> I'm really starting to like the idea of introducing "="
> as an alternative for ":" :
> "=" assumes relative paths, ":" assumes absolute (full) paths.
> That could be Junio's new metacharacter.

Just keep in mind: "once introduced, you'll never be able to remove it".
And I don't share your feelings regarding the special character, for instance.

I'd suggest to define a special character for _top_ level. Real pity
":/" is taken.

  reply	other threads:[~2007-05-04  9:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-04  7:18 [PATCH] Support ent:relative_path Dana How
2007-05-04  7:22 ` Dana How
2007-05-04  8:21   ` Junio C Hamano
2007-05-04  8:45     ` Dana How
2007-05-04  8:47     ` Alex Riesen
2007-05-04  8:53       ` Dana How
2007-05-04  9:17         ` Alex Riesen [this message]
2007-05-04  9:26           ` Dana How
2007-05-04  9:46             ` Alex Riesen
2007-05-04 16:57               ` Dana How
2007-05-04 17:17                 ` Alex Riesen
2007-05-04 19:00                   ` Johannes Schindelin
2007-05-04 20:23                     ` Alex Riesen
2007-05-04  9:19       ` Johannes Sixt
2007-05-04 17:17         ` Junio C Hamano
2007-05-04 18:23           ` Dana How
2007-05-04 19:06           ` Johannes Schindelin
2007-05-04 19:22             ` Junio C Hamano
2007-05-04 19:31               ` Johannes Schindelin
2007-05-04 19:38                 ` Junio C Hamano
2007-05-04 19:42                   ` Johannes Schindelin
2007-05-04 20:21           ` Alex Riesen
2007-05-04 23:36           ` Jakub Narebski
2007-05-05  0:04             ` Junio C Hamano
2007-05-05  0:52               ` Dana How
2007-05-05  1:06                 ` Jakub Narebski
2007-05-05  1:15                 ` Junio C Hamano
2007-05-04  8:20 ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0705040217o54d1d028j6e768bdc3eb0bad0@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=danahow@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).