From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Liu Yubao" <yubao.liu@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] remove unnecessary loop
Date: Tue, 8 May 2007 11:08:35 +0200 [thread overview]
Message-ID: <81b0412b0705080208x3713cbc1y3c870383b586c877@mail.gmail.com> (raw)
In-Reply-To: <4640015F.1080407@gmail.com>
On 5/8/07, Liu Yubao <yubao.liu@gmail.com> wrote:
> +#ifdef __CYGWIN__
> + /*
> + * On cygwin, lstat("hello", &st) returns 0 when
> + * "hello.exe" exists, so test with open() again.
> + */
> + if (lstat(match, &st) && -1 != (fd = open(match, O_RDONLY))) {
This does not "test again" if lstat returns 0. If lstat returns 0
(file stat info
obtained) the open is not even called. Besides, cygwin lies not only about
.exe but also about .lnk files.
P.S. Somehow I have the feeling that even if it is a stupidity in cygwin
they will not fix it (nor will they admit it is a bug).
next prev parent reply other threads:[~2007-05-08 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 3:18 [PATCH] remove unnecessary loop Liu Yubao
2007-05-08 4:49 ` Liu Yubao
2007-05-08 5:05 ` Junio C Hamano
2007-05-08 9:08 ` Alex Riesen [this message]
2007-05-08 10:13 ` Jan Hudec
2007-05-08 12:38 ` Alex Riesen
2007-05-08 12:17 ` Eric Blake
2007-05-08 9:39 ` Jan Hudec
2007-05-09 1:03 ` Liu Yubao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0705080208x3713cbc1y3c870383b586c877@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=yubao.liu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).