git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, "Sven Verdoolaege" <skimo@kotnet.org>
Subject: Re: git-filter-branch exits early
Date: Wed, 11 Jul 2007 08:02:54 +0200	[thread overview]
Message-ID: <81b0412b0707102302i34a51baax464f8c7c69087b7d@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0707102222430.4047@racer.site>

On 7/10/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> On Tue, 10 Jul 2007, Alex Riesen wrote:
>
> > I have a Debian system where git-filter-branch exits immediately after
> > "unset CDPATH" in git-sh-setup (the command exits with 1, as CDPATH is
> > not defined). The system still has bash-2.05a.
> >
> > git-filter-branch has "set -e", which is why the script finishes
> > prematurely. If this is not really needed, maybe it can be removed?
> >
> > I'll see if the system can be upgraded, but I suspect someone can get
> > a similar problem.
>
> I do not really understand why "unset CDPATH" should trigger an error.  I
> guess that this is one of the nice braindamages in dash, right?

in bash. Bash-2.05.a

> Anyway, "set -e" was one thing I wanted to fix. ...

BTW, what can break if I just go on and remove it?

> - since it is a C program, it should be more stable, eventually, than a
>   shell script, where you have to work around limitations all the time,

right :)

  reply	other threads:[~2007-07-11  6:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-10 20:52 git-filter-branch exits early Alex Riesen
2007-07-10 21:57 ` Johannes Schindelin
2007-07-11  6:02   ` Alex Riesen [this message]
2007-07-11  7:55   ` Sven Verdoolaege
2007-07-18 13:17 ` [PATCH] filter-branch: get rid of "set -e" Johannes Schindelin
2007-07-18 13:27   ` David Kastrup
2007-07-18 14:05     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0707102302i34a51baax464f8c7c69087b7d@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=skimo@kotnet.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).