From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Johannes Sixt" <j.sixt@viscovery.net>,
"Git Mailing List" <git@vger.kernel.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Kristian Høgsberg" <krh@redhat.com>
Subject: Re: [PATCH] builtin-commit: add --cached to operate only on index
Date: Tue, 27 Nov 2007 19:12:30 +0100 [thread overview]
Message-ID: <81b0412b0711271012v67f1058fj8c0de8e511543d4e@mail.gmail.com> (raw)
In-Reply-To: <7vfxyrd2x2.fsf@gitster.siamese.dyndns.org>
On 27/11/2007, Junio C Hamano <gitster@pobox.com> wrote:
> I am sympathetic to the _cause_, but I do not think the option --cached
> is a good match for this change. As Hannes points out, as-is commit is
> the default, and --cached to other commands mean "work only with index
> not work tree", not "short-circuit for systems with slow lstat(3)".
I don't just mean to avoid lstat. I'm trying to avoid _any_
interaction with the thing unless absolutely needed.
> * The option "--cached" is a wrong thing to have the user say and is
> not what you want anyway. You want "no status list in the commit log
> template";
That is not what I meant to say. I do want status list in commit message.
I don't want anything except git-diff-index --name-status --cached HEAD in it.
No untracked files whatsoever.
And, as I said, I also just want to commit the index _exactly_ as it is.
No checking for files changed after they were updated in the index
intended. I think that whatever the index holds is perfect (except it's
no different from HEAD) and I want commit it now.
> * Skip run_status() and replace with "diff-index --cached HEAD" (or "is
> the index empty?") when the user instructs so;
Right. Is it not what happens with the patch?
next prev parent reply other threads:[~2007-11-27 18:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 10:54 [PATCH] builtin-commit: add --cached to operate only on index Alex Riesen
2007-11-27 11:18 ` Johannes Schindelin
2007-11-27 12:57 ` Alex Riesen
2007-11-27 11:35 ` Johannes Sixt
2007-11-27 12:48 ` Alex Riesen
2007-11-27 17:16 ` Junio C Hamano
2007-11-27 18:12 ` Alex Riesen [this message]
2007-11-27 18:18 ` Alex Riesen
2007-11-27 21:44 ` [PATCH] Do not generate full commit log message if it not going to be used Alex Riesen
2007-11-27 21:47 ` Alex Riesen
2007-11-28 12:18 ` Johannes Schindelin
2007-11-28 21:10 ` Alex Riesen
2007-11-28 21:13 ` [PATCH] Do not generate full commit log message if it is " Alex Riesen
2007-11-28 21:43 ` [PATCH] Do not generate full commit log message if it " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0711271012v67f1058fj8c0de8e511543d4e@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).