git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>, "Kevin Ballard" <kevin@sb.org>
Subject: [PATCH] Fix t3700 on filesystems which do not support question marks in names
Date: Fri, 15 Aug 2008 09:11:23 +0200	[thread overview]
Message-ID: <81b0412b0808150011r534d8453yab2a5c42b255657f@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

And the prominent example of the deficiency are, as usual, the filesystems
of Microsoft house.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 t/t3700-add.sh |   19 ++++++++++++-------
 1 files changed, 12 insertions(+), 7 deletions(-)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-t3700-on-filesystems-which-do-not-support-questi.patch --]
[-- Type: text/x-patch; name=0001-Fix-t3700-on-filesystems-which-do-not-support-questi.patch, Size: 1323 bytes --]

From 2e5bbfea6a3ee6ff8cf82599cec0e49de94d0631 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Fri, 15 Aug 2008 09:00:54 +0200
Subject: [PATCH] Fix t3700 on filesystems which do not support question marks in names

And the prominent example of the deficiency are, as usual, the filesystems
of Microsoft house.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 t/t3700-add.sh |   19 ++++++++++++-------
 1 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 77a782c..2fa907e 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -222,12 +222,17 @@ test_expect_success 'git add (add.ignore-errors = false)' '
 	! ( git ls-files foo1 | grep foo1 )
 '
 
-test_expect_success 'git add '\''fo\?bar'\'' ignores foobar' '
-	git reset --hard &&
-	touch fo\?bar foobar &&
-	git add '\''fo\?bar'\'' &&
-	git ls-files fo\?bar | grep -F fo\?bar &&
-	! ( git ls-files foobar | grep foobar )
-'
+if touch fo\?bar
+then
+	test_expect_success 'git add '\''fo\?bar'\'' ignores foobar' '
+		git reset --hard &&
+		touch foobar &&
+		git add '\''fo\?bar'\'' &&
+		git ls-files fo\?bar | grep -F fo\?bar &&
+		! ( git ls-files foobar | grep foobar )
+	'
+else
+	say "The filesystem does not support ? in names, some tests skipped"
+fi
 
 test_done
-- 
1.6.0.rc2.68.g49fa3


             reply	other threads:[~2008-08-15  7:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15  7:11 Alex Riesen [this message]
2008-08-15  7:17 ` [PATCH] Fix t3700 on filesystems which do not support question marks in names Junio C Hamano
2008-08-15  7:23   ` Alex Riesen
2008-08-15  7:32     ` Alex Riesen
2008-08-15  8:23       ` Kevin Ballard
2008-08-15  8:30         ` Kevin Ballard
2008-08-15  9:01       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0808150011r534d8453yab2a5c42b255657f@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kevin@sb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).