From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>, "Kevin Ballard" <kevin@sb.org>
Subject: [PATCH] Fix t3700 on filesystems which do not support question marks in names
Date: Fri, 15 Aug 2008 09:32:30 +0200 [thread overview]
Message-ID: <81b0412b0808150032o20f69346jb4f573b78cd11f2b@mail.gmail.com> (raw)
In-Reply-To: <81b0412b0808150023sd30559fi68ff1e439013f26e@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
Use square brackets instead.
And the prominent example of the deficiency are, as usual, the filesystems
of Microsoft house.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
2008/8/15 Junio C Hamano <gitster@pobox.com>:
>>> And the prominent example of the deficiency are, as usual, the filesystems
>>> of Microsoft house.
>>
>> Can other glob specials such as '*' or '[' be used instead of skipping the
>> test?
>
> Ah... The brackets are allowed.
Sorry, should have thought of it.
t/t3700-add.sh | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-t3700-on-filesystems-which-do-not-support-questi.patch --]
[-- Type: text/x-patch; name=0001-Fix-t3700-on-filesystems-which-do-not-support-questi.patch, Size: 1179 bytes --]
From 3a25527fa61463d5968586efa1f3474008bbe2d4 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Fri, 15 Aug 2008 09:00:54 +0200
Subject: [PATCH] Fix t3700 on filesystems which do not support question marks in names
Use square brackets instead.
And the prominent example of the deficiency are, as usual, the filesystems
of Microsoft house.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
t/t3700-add.sh | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 77a782c..2ac93a3 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -222,11 +222,11 @@ test_expect_success 'git add (add.ignore-errors = false)' '
! ( git ls-files foo1 | grep foo1 )
'
-test_expect_success 'git add '\''fo\?bar'\'' ignores foobar' '
+test_expect_success 'git add '\''fo\[ou\]bar'\'' ignores foobar' '
git reset --hard &&
- touch fo\?bar foobar &&
- git add '\''fo\?bar'\'' &&
- git ls-files fo\?bar | grep -F fo\?bar &&
+ touch fo\[ou\]bar foobar &&
+ git add '\''fo\[ou\]bar'\'' &&
+ git ls-files fo\[ou\]bar | grep -F fo\[ou\]bar &&
! ( git ls-files foobar | grep foobar )
'
--
1.6.0.rc2.68.g49fa3
next prev parent reply other threads:[~2008-08-15 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 7:11 [PATCH] Fix t3700 on filesystems which do not support question marks in names Alex Riesen
2008-08-15 7:17 ` Junio C Hamano
2008-08-15 7:23 ` Alex Riesen
2008-08-15 7:32 ` Alex Riesen [this message]
2008-08-15 8:23 ` Kevin Ballard
2008-08-15 8:30 ` Kevin Ballard
2008-08-15 9:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0808150032o20f69346jb4f573b78cd11f2b@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kevin@sb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).