git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] Extend "checkout --track" DWIM to support more cases
Date: Fri, 22 Aug 2008 11:08:01 +0200	[thread overview]
Message-ID: <81b0412b0808220208i5de03604rec37081f0bc1cdd4@mail.gmail.com> (raw)
In-Reply-To: <7vy72pd278.fsf@gitster.siamese.dyndns.org>

2008/8/22 Junio C Hamano <gitster@pobox.com>:
> I however wonder if this is clearer.

It is :)

>  * "enum branch_track" was unsigned; comparing equality with -1 was Ok but
>   we couldn't say 0 < opts.track;
>
>  * argv[] is an array of constant strings; cannot point into it with
>   opts.newbranch without making the latter also a constant string.

Cleanup, but it is unrelated, isn't it?

>  * the logic is to strip "refs/" if there is one, "remotes/" if there is
>   one after that, and then strip one level after that unconditionally.
>   No need to look explicitly for a slash while doing the first two steps.

Maybe that should go in documentation instead of the piece I wrote

  reply	other threads:[~2008-08-22  9:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20 18:50 [PATCH] Extend "checkout --track" DWIM to support more cases Alex Riesen
2008-08-20 19:52 ` Johannes Schindelin
2008-08-20 20:04   ` Alex Riesen
2008-08-20 20:16     ` Johannes Schindelin
2008-08-20 20:29       ` Alex Riesen
2008-08-20 22:22         ` Junio C Hamano
2008-08-21 17:23           ` Alex Riesen
2008-08-22  5:54             ` Junio C Hamano
2008-08-22  9:08               ` Alex Riesen [this message]
2008-08-22 21:17                 ` Junio C Hamano
2008-08-22 23:33             ` Jay Soffian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0808220208i5de03604rec37081f0bc1cdd4@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).