From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <junkio@cox.net>
Subject: [PATCH] Fix use of hardlinks in "make install"
Date: Thu, 28 Aug 2008 16:04:29 +0200 [thread overview]
Message-ID: <81b0412b0808280704h585b6cb4nf03e509de0159a91@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
The code tried to create a hardlink to the file ($execdir/git-add) it just
removed, so ln failed (but because stderr was redirected into /dev/null the
error was never seen), and the whole install ended up using "ln -s" instead.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
It created endless symlink loops on cygwin, but obviously nowhere else.
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-use-of-hardlinks-in-make-install.patch --]
[-- Type: text/x-patch; name=0001-Fix-use-of-hardlinks-in-make-install.patch, Size: 1160 bytes --]
From 943e0824b9fd1a8c2798ae9fd341b6a9b7429cc1 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 28 Aug 2008 15:57:32 +0200
Subject: [PATCH] Fix use of hardlinks in "make install"
The code tried to create a hardlink to the file ($execdir/git-add) it just
removed, so ln failed (but because stderr was redirected into /dev/null the
error was never seen), and the whole install ended up using "ln -s" instead.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index bf400e6..20a1704 100644
--- a/Makefile
+++ b/Makefile
@@ -1380,7 +1380,7 @@ endif
ln git-add$X "$$execdir/git-add$X" 2>/dev/null || \
cp git-add$X "$$execdir/git-add$X"; } && \
{ $(foreach p,$(filter-out git-add,$(BUILT_INS)), $(RM) "$$execdir/$p" && \
- ln "$$execdir/git-add$X" "$$execdir/$p" 2>/dev/null || \
+ ln "git-add$X" "$$execdir/$p" || \
ln -s "git-add$X" "$$execdir/$p" 2>/dev/null || \
cp "$$execdir/git-add$X" "$$execdir/$p" || exit;) } && \
./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"
--
1.6.0.1.150.g8307.dirty
next reply other threads:[~2008-08-28 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 14:04 Alex Riesen [this message]
2008-08-28 14:17 ` [PATCH] Fix use of hardlinks in "make install" Alex Riesen
2008-08-28 14:30 ` Alex Riesen
2008-08-30 0:20 ` [PATCH/resend] " Alex Riesen
2008-08-30 8:59 ` Andreas Färber
2008-08-30 10:08 ` Alex Riesen
2008-08-30 11:39 ` Andreas Färber
2008-08-30 15:48 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0808280704h585b6cb4nf03e509de0159a91@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).