From: "Alex Riesen" <raa.lkml@gmail.com>
To: "David Bryson" <david@statichacks.org>
Cc: "Andreas Ericsson" <ae@op5.se>, git@vger.kernel.org
Subject: Re: [PATCH] Use "git_config_string" to simplify "remote.c" code in "handle_config"
Date: Sun, 5 Oct 2008 00:46:29 +0200 [thread overview]
Message-ID: <81b0412b0810041546w5eed8859vd8266bb66425ebd3@mail.gmail.com> (raw)
In-Reply-To: <20081003200613.GO20571@eratosthenes.cryptobackpack.org>
2008/10/3 David Bryson <david@statichacks.org>:
> On Fri, Oct 03, 2008 at 07:28:42AM +0200 or thereabouts, Andreas Ericsson wrote:
>> David Bryson wrote:
> Oh I agree entirely, it is quite vague, however like I mentioned I tried
> to keep to the conventios in the file. This strategy(v) is used in several
> other places in remote.c, if this is Bad Code, then I have no problem
> changing it.
>
> Thoughts from anybody else ?
>
You can redeclare of the variable in the contexts where
it is used and not even rename it: it is close to its users then.
next prev parent reply other threads:[~2008-10-04 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 3:39 [PATCH] Use "git_config_string" to simplify "remote.c" code in "handle_config" David Bryson
2008-10-03 5:28 ` Andreas Ericsson
2008-10-03 20:06 ` David Bryson
2008-10-04 22:46 ` Alex Riesen [this message]
2008-10-06 19:49 ` David Bryson
2008-10-06 14:13 ` Johannes Schindelin
2008-10-06 19:53 ` David Bryson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0810041546w5eed8859vd8266bb66425ebd3@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=ae@op5.se \
--cc=david@statichacks.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).