From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Daniel Barkalow" <barkalow@iabervon.org>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [RFC PATCH 4/3] Add example git-vcs-p4
Date: Mon, 12 Jan 2009 12:46:32 +0100 [thread overview]
Message-ID: <81b0412b0901120346x79772846p6e5097028fc9720c@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.1.00.0901110336380.19665@iabervon.org>
2009/1/11 Daniel Barkalow <barkalow@iabervon.org>:
> diff --git a/Makefile b/Makefile
>
> +LIB_OBJS += p4client.o
> +LIB_OBJS += vcs-p4.o
> +
>
> +extern int cmd_p4(int argc, const char **argv, const char *prefix);
> +
Why is your foreign VCS importer built-in? The majority wont ever need it,
yet they have to pay the price for its text being in git executable.
next prev parent reply other threads:[~2009-01-12 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 20:12 [RFC PATCH 4/3] Add example git-vcs-p4 Daniel Barkalow
2009-01-12 2:08 ` Junio C Hamano
2009-01-12 5:41 ` Daniel Barkalow
2009-01-12 6:29 ` Junio C Hamano
2009-01-12 11:46 ` Alex Riesen [this message]
2009-01-12 18:36 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0901120346x79772846p6e5097028fc9720c@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).