log-tree.c: date hardwired

log-tree.c: date hardwired

[jidanni]

In log-tree.c: printf("From %s Mon Sep 17 00:00:00 2001\n", name);
Wouldn't it be more aesthetically pleasing to use current local or UTC time?
Or at least comment in the code that the date is hardwired like that
in the fear that otherwise people will think it is the actual commit time.
No, I can't think of any other tool that hardwires the From separators
they produce.

Re: log-tree.c: date hardwired

[jidanni]

Can I get a go-ahead from somebody for me to begin work on implementing a fix?
(Yes, trivial.)

>>>>> "j" == jidanni  <jidanni@jidanni.org> writes:

j> In log-tree.c: printf("From %s Mon Sep 17 00:00:00 2001\n", name);
j> Wouldn't it be more aesthetically pleasing to use current local or UTC time?
j> Or at least comment in the code that the date is hardwired like that
j> in the fear that otherwise people will think it is the actual commit time.
j> No, I can't think of any other tool that hardwires the From separators
j> they produce.

Re: log-tree.c: date hardwired

[Alex Riesen]

2009/1/18  <jidanni@jidanni.org>:
> Can I get a go-ahead from somebody for me to begin work on implementing a fix?

No. Try and guess why

Re: log-tree.c: date hardwired

[jidanni]

Perhaps a comment could be added to the code as to the reason a date
or that certain date is hardwired. Any reason would be satisfactory.

Re: log-tree.c: date hardwired

[Sitaram Chamarty]

On 2009-01-17, Alex Riesen <raa.lkml@gmail.com> wrote:
> 2009/1/18  <jidanni@jidanni.org>:
>> Can I get a go-ahead from somebody for me to begin work
>> on implementing a fix?
>
> No. Try and guess why

OK, I'll bite...

Because it's only used as the date for the mbox format
leader line, and not an actual email (RFC 822/2822) header
line?  And in that format it represents "delivery date",
which is irrelevant for stuff you're generating to be sent
out anyway, meaning this line doesn't actually get sent out
to anyone when you mail your patches, so we don't care what
it is.

I can't think of anything else, so if it isn't that please
do tell.  Not that I cared about it before, but once someone
says "try and guess why" it somehow becomes important :-)

Re: log-tree.c: date hardwired

[Junio C Hamano]

jidanni@jidanni.org writes:

> Can I get a go-ahead from somebody for me to begin work on implementing a fix?

No, don't "fix" it.

Please keep it as a known constant.  That way, you can come up with an
/etc/magic entry to teach find(1) that it is not just a random mailbox but
is an output from format-patch.